perf: list contains scalar scalar #5792
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ax1
added
the
performance
0ax1
force-pushed
the
ad/list-contains
branch
2 times, most recently
from
7698e3c to
7155099
Compare
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
0ax1
force-pushed
the
ad/list-contains
branch
from
7155099 to
e30d39c
Compare
Comment on lines
+340
to
+341
| list: &ListViewScalar, | ||
| needle: &vortex_vector::Scalar, |
Contributor
There was a problem hiding this comment.
should this method be in vortex-compute?
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| }) | ||
| } else { | ||
| // Fallback for non-primitive vectors | ||
| (0..elements.len()).any(|i| needle == &elements.scalar_at(i)) |
Contributor
There was a problem hiding this comment.
can we use a array compare here with the elements and a constant array?
Contributor
There was a problem hiding this comment.
shouldn't need to special case anything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.